Sheffield | 26-Jan-ITP | Mona-Elatntawy | Sprint 2 | Form-control#1089
Open
Mona-Eltantawy wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-Jan-ITP | Mona-Elatntawy | Sprint 2 | Form-control#1089Mona-Eltantawy wants to merge 5 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
- size -colour -quantity
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Mona-Eltantawy
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Mona-Eltantawy
changed the title
Mona-Eltantawy
added
the
Needs Review
Mona-Eltantawy
changed the title
Mona-Eltantawy
added
📅 Sprint 2
cjyuan
reviewed
Jan 29, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
Form-Controls/index.html
Outdated
Comment on lines
28
to
33
| <div> | ||
| <label for="password">Password</label><br> | ||
| <input id="password" name="password" type="password" placeholder="At least 8 characters" minlength="8" | ||
| autocomplete="current-password" required size="30"> | ||
| </div><br> | ||
|
|
Contributor
There was a problem hiding this comment.
It is good that you are trying different input elements. It is just unusual to have a password field in a T-shirt ordering form.
Author
There was a problem hiding this comment.
Thank you CJ. I deleted the 'password' input.
can you please re-review it.
cjyuan
added
Reviewed
Mona-Eltantawy
added
the
Needs Review
Contributor
|
You missed this comment, :)
|
cjyuan
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist